This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
gdb/CONTRIBUTE
- From: Pedro Alves <palves at redhat dot com>
- To: Victor Kamensky <victor dot kamensky at linaro dot org>, Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 24 Oct 2014 13:20:20 +0100
- Subject: gdb/CONTRIBUTE
- Authentication-results: sourceware.org; auth=none
- References: <1413853021-4393-1-git-send-email-victor dot kamensky at linaro dot org> <1413853021-4393-3-git-send-email-victor dot kamensky at linaro dot org> <871tq1kgc2 dot fsf at codesourcery dot com> <CAA3XUr30j06803k3-4uD3vvpuB7hcXk4q6N=Jzgx2-0SoOHLWQ at mail dot gmail dot com>
Hi Victor,
On 10/21/2014 03:44 PM, Victor Kamensky wrote:
>> >
>> > We don't include the ChangeLog changes in the patch, because that will
>> > cause conflicts when applying your patch locally in the review.
>> > Instead, we include ChangeLog entries in the commit messages, see
>> > https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
> Thanks! It is good pointer. I have not seen it before.
> Maybe gdb/CONTRIBUTE could mention this wiki page.
OOC, how did you find gdb/CONTRIBUTE? Was that through
https://sourceware.org/gdb/contribute/ or some other means?
IMO we should just move/merge the gross of the contents in the
file to the web/wiki, and either delete the file, or leave just
the preamble.
If it stays, I think it should link to:
http://www.gnu.org/software/gdb/contribute/
as that's more stable than the wiki, and then that page should
link to relevant wiki pages.
Thanks,
Pedro Alves