This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
- From: Doug Evans <dje at google dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 23 Oct 2014 22:31:09 -0700
- Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzAMpiA8Hwt1=DqmFxXjfe44nqGsCqsj-fx=ObJbgPAsA at mail dot gmail dot com> <CAGyQ6gy9eObF+29DSibKj4xxiw9NpoWtarVJTtd-j_A7LBnktA at mail dot gmail dot com> <CAGyQ6gzXKBQ4JVOZeEUAc3fvDtXJ+yACsU74rL2Q4cnO4JTh+g at mail dot gmail dot com>
On Thu, Oct 23, 2014 at 12:09 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Oct 16, 2014 at 12:01 PM, Siva Chandra <sivachandra@google.com> wrote:
>> The patch updated with a test case is attached.
>>
>> gdb/ChangeLog:
>>
>> * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE
>> on the arg type of a constructor only if it is of reference type.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.cp/non-trivial-retval.cc: Add a test case.
>> * gdb.cp/non-trivial-retval.exp: Add a test.
>
> Ping.
LGTM with one nit.
+class B1
+{
+public:
+ B1 () {}
+ B1 (int i); /* Put this decl before the copy-ctor decl. */
+ B1 (const B1 &obj);
+
+ int b1;
+};
Can you elaborate on why "Put this decl before ..."?