This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2] Make chained function calls in expressions work
- From: Siva Chandra <sivachandra at google dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 23 Oct 2014 16:31:05 -0700
- Subject: Re: [PATCH 0/2] Make chained function calls in expressions work
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gwpWzAWe01pUvd3Wgv1m1Yai-b3H2rw7Dq+3Hv_zca6pw at mail dot gmail dot com> <201410231609 dot s9NG9ZvU004472 at d06av02 dot portsmouth dot uk dot ibm dot com>
On Thu, Oct 23, 2014 at 9:09 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> In this case, I agree with the rest of your explanation. Please add a
> comment in the final version of the patch that explains why the extra
> copy is necessary.
>
> There's just one minor change I think would be good: can we allocate that
> extra copy on the stack at least only for *class* types, then? I'd prefer
> to avoid this for the common case of routines just returning a scalar.
I will soon send a new version of the patch with all the suggested
changes in this thread.
Thanks,
Siva Chandra