This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V2 7/9] Simple testsuite for DTrace USDT probes.
- From: Pedro Alves <palves at redhat dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 17 Oct 2014 13:17:56 +0100
- Subject: Re: [PATCH V2 7/9] Simple testsuite for DTrace USDT probes.
- Authentication-results: sourceware.org; auth=none
- References: <1412961772-16249-1-git-send-email-jose dot marchesi at oracle dot com> <1412961772-16249-8-git-send-email-jose dot marchesi at oracle dot com> <54404878 dot 50406 at redhat dot com> <87bnpa3nwm dot fsf at oracle dot com>
Hi Jose,
On 10/17/2014 01:02 PM, Jose E. Marchesi wrote:
> Thanks for your suggestions. Please take a look to this new version of
> the patch. I think it addresses all your concerns :)
Indeed it does. Thanks much.
One tiny nit:
> + if {[dtrace_build_usdt_test_program] == -1} {
> + untested ${testfile}.exp
> + return -1
> + }
Something odd with indentation there.
"untested ${testfile}.exp" is an anti-idiom in lots of tests :-)
See https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#A.22untested.22_calls .
Write instead:
untested "could not compile test program"
Otherwise looks good.
Thanks,
Pedro Alves