This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
- From: Siva Chandra <sivachandra at google dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 16 Oct 2014 11:18:24 -0700
- Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzAMpiA8Hwt1=DqmFxXjfe44nqGsCqsj-fx=ObJbgPAsA at mail dot gmail dot com> <544007F1 dot 9010005 at redhat dot com> <CAGyQ6gz3DfAA52yh0ANFyJycMnAc5oQLmG6p+x6R70G7cbmuYQ at mail dot gmail dot com> <87r3y7j2xw dot fsf at redhat dot com>
On Thu, Oct 16, 2014 at 11:15 AM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Thursday, October 16 2014, Siva Chandra wrote:
>
>> Do you think a test case should be added? I did think about it, but
>> then, should there be a test case for every use of TYPE_TARGET_TYPE? I
>> thought it was more of a "user mistake" in my original patch.
>
> If I may, I think a testcase should be added for this case, yes. GDB
> should not have a problem because a user mistake.
I will add and send an updated patch. The user mistake I am talking
about here is me as a developer using "TYPE_TARGET_TYPE" in GDB source
code.