This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Match the working directory on remote host


On 10/16/2014 02:39 PM, Yao Qi wrote:
> The test in gdb.python/python.exp tests "extended-prompt" and expects
> working directory is printed.  However, working directory on remote
> host doesn't have "gdb/testsuite", so the test fails on remote host
> like:
> 
> set extended-prompt \w ^M
> ^M
> /home/yao FAIL: gdb.python/python.exp: set extended prompt working directory (timeout)
> 
> This patch is to get the working directory first, and use it to match
> the output of "set extended-prompt \\w ".  It works for remote host
> and non remote host.
> 

Looks good.

>  gdb_test_multiple "set extended-prompt \\w " \
>      "set extended prompt working directory" {
> -    -re "\[\r\n\].*gdb.*testsuite.* $" {
> +	-re "\[\r\n\]${working_dir} $" {

Please don't change the indentation though.

>  	pass "set extended prompt working directory"
>      }
>  }

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]