This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial
- From: Siva Chandra <sivachandra at google dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 14 Oct 2014 18:10:26 -0700
- Subject: Re: [PATCH 4/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to treat dynamic classes as non-trivial
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gwUDdJh+oUxJxhgSXfY90cp2hkh-+mN0wEcJp90naBXog at mail dot gmail dot com> <CADPb22Q6KH+i=Jwho3B2a-DACjYFrgFby0uG0LEnfOi3d=9HZg at mail dot gmail dot com> <CAGyQ6gw+4OZgoaj3P+Nv+wjTKqCtde_zZ9nP9qDLfd4wxFsYpA at mail dot gmail dot com> <21565 dot 36622 dot 673293 dot 934684 at ruffy2 dot mtv dot corp dot google dot com>
On Tue, Oct 14, 2014 at 2:01 PM, Doug Evans <dje@google.com> wrote:
> It'd be really nice to include a reference to the spec here.
> I don't know about others, but this stuff is not the kind of
> thing I tend to keep in cache, and when reading such code
> it's really nice to be able to find the relevant sections
> of the spec without any effort.
>
> Does the following make sense?
>
> + /* A dynamic class has a non-trivial copy constructor.
> + See c++98 section 12.8 Copying class objects [class.copy]. */
> + if (gnuv3_dynamic_class (type))
> + return 1;
> +
Thanks Doug. I will push this patch set after adding the above comment.