This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args
- From: Doug Evans <dje at google dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 14 Oct 2014 14:03:04 -0700
- Subject: Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gzqbyL-ushbTo9u0iccvmhJnekwa8EDxdL3xCJMkGcEYQ at mail dot gmail dot com> <CADPb22RoEi+AKN+==ZcK-K8MR80gvVje7iaHT7ThMQJ9ibmKWA at mail dot gmail dot com> <CAGyQ6gxdno4x2dxQ==-d3A4UxRGJjE18y-xPAdLWqxA06cgQhw at mail dot gmail dot com>
Siva Chandra writes:
> On Sun, Sep 28, 2014 at 11:01 PM, Doug Evans <dje@google.com> wrote:
> >> 2014-09-11 Siva Chandra Reddy <sivachandra@google.com>
> >>
> >> PR c++/13403
> >> PR c++/15154
> >> * gdbtypes.c (make_qualified_type): Make non-static.
> >> * gdbtypes.h (make_qualified_type): Declare.
> >> * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy
> >> constructors with qualified args
>
> > Can you use class_types_same_p here (instead of comparing with the
> > result of make_qualified_type) ?
>
> Yes, I made this change now. The patch is attached.
>
> I am assuming that the other patches in this series are approved
> modulo making the test regexes more specific.
>
> gdb/ChangeLog:
>
> 2014-09-29 Siva Chandra Reddy <sivachandra@google.com>
>
> PR c++/13403
> PR c++/15154
> * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy constructors
> with qualified args.
LGTM.
And yeah, the rest of the patch set is approved.
[Modulo the potential addition of a comment in 4/4.]