This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/9] New gdbarch functions: dtrace_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe.
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 18:38:56 +0200
- Subject: Re: [PATCH 4/9] New gdbarch functions: dtrace_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe.
- Authentication-results: sourceware.org; auth=none
- References: <1411724905-31234-1-git-send-email-jose dot marchesi at oracle dot com> <1411724905-31234-5-git-send-email-jose dot marchesi at oracle dot com> <874mvmupep dot fsf at redhat dot com>
> diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
> index 2a8bca8..0458134 100755
> --- a/gdb/gdbarch.sh
> +++ b/gdb/gdbarch.sh
> @@ -944,6 +944,21 @@ M:int:stap_is_single_operand:const char *s:s
> # parser), and should advance the buffer pointer (p->arg).
> M:int:stap_parse_special_token:struct stap_parse_info *p:p
>
> +# DTrace related functions.
> +
> +# The expression to compute the NARTGth+1 argument to a DTrace USDT probe.
> +# NARG must be >= 0.
> +M:void:dtrace_probe_argument:struct parser_state *pstate, int narg:pstate, narg
This function is responsible for parsing the argument, right? I'd
prefer if you named it "dtrace_parse_probe_argument". WDYT?
Yes, I agree, that name is better. Changed in the patch.