This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Use command "monitor set debug 0" to check the connection
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 10:38:10 +0100
- Subject: Re: [PATCH 3/3] Use command "monitor set debug 0" to check the connection
- Authentication-results: sourceware.org; auth=none
- References: <543404EF dot 4010306 at redhat dot com> <1412749679-27076-1-git-send-email-yao at codesourcery dot com> <1412749679-27076-4-git-send-email-yao at codesourcery dot com> <543547FC dot 30306 at redhat dot com> <87zjd6rlof dot fsf at codesourcery dot com>
On 10/09/2014 04:01 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> That error is printed by trace_status_command, but only after calling
>> target_get_trace_status, which seems to me should be sending a packet.
>>
>> remote_get_trace_status's exception swallowing should be
>> letting TARGET_CLOSE_ERROR pass through. Is that not working?
>> I'm a bit confused because it seems like if that didn't work,
>> we should see a "qTStatus:..." error line in the logs.
>>
>> So what is preventing the packet from being sent?
>
> qTStatus is disabled after receiving the empty reply during connecting
> to the remote target.
Ah, thanks. I missed that we request the trace status on connection.
So I think we should do "set remote trace-status-packet on" before
the "tstatus".
I know that the test originally didn't use "tstatus",
but it's really the packet we should be testing for exercising
that remote_get_trace_status's exception swallowing code,
which was very much related to the original bug this test covered,
see:
https://sourceware.org/bugzilla/show_bug.cgi?id=15275
https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html
Thanks,
Pedro Alves