This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Clean up server-kill.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 08 Oct 2014 14:48:50 +0100
- Subject: Re: [PATCH 1/3] Clean up server-kill.exp
- Authentication-results: sourceware.org; auth=none
- References: <543404EF dot 4010306 at redhat dot com> <1412749679-27076-1-git-send-email-yao at codesourcery dot com> <1412749679-27076-2-git-send-email-yao at codesourcery dot com>
On 10/08/2014 07:27 AM, Yao Qi wrote:
> This patch is to remove some lines which looks unnecessary. These
> lines were added when server-kill.exp was added. In the version 1,
> https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test
> calls runto_main and delete breakpoint on main,
>
> +if ![runto_main] {
> + return -1
> +}
> +
> +# Otherwise the breakpoint at 'main' would not cause insert breakpoints during
> +# first step.
> +delete_breakpoints
>
> However, in the version 2
> https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main
> is removed but delete_breakpoints is still there. AFAICS, the line of
> delete_breakpoints can be removed too.
>
> gdb/testsuite:
>
> 2014-10-08 Yao Qi <yao@codesourcery.com>
>
> * gdb.server/server-kill.exp: Remove "delete_breakpoints".
OK.
Thanks,
Pedro Alves