This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/9] Decide whether we may have removed breakpoints based on step_over_info
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 06 Oct 2014 09:42:30 +0100
- Subject: Re: [PATCH 1/9] Decide whether we may have removed breakpoints based on step_over_info
- Authentication-results: sourceware.org; auth=none
- References: <1411691982-10744-1-git-send-email-palves at redhat dot com> <1411691982-10744-2-git-send-email-palves at redhat dot com> <87fvfbx65x dot fsf at codesourcery dot com> <542D93F8 dot 7050005 at redhat dot com> <87oatqui22 dot fsf at codesourcery dot com>
On 10/06/2014 02:02 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> I.e., if we have step-over info, then something, somewhere wants a
>> breakpoint lifted out of the target. No matter whether we're
>> stepping or continuing the target at this point, we need to receive
>> all signals so that if the signal handler calls the code that
>> would trigger the breakpoint/watchpoint, we don't miss it.
>>
>> Removing this check now avoids having tweak it when
>> singlestep_breakpoints_inserted_p check global ends up
>> eliminated by a later patch in the series.
>>
>> Does that make sense?
>
> Yes, it makes sense to me.
>
> I've reviewed the rest of patches, and they are good to me. I've tested
> the whole patch set with the changes I suggested in patch 3/9 on
> arm-linux-gnueabi target. No regression.
Excellent. Thank you very much, Yao.
Thanks,
Pedro Alves