This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Sun, 28 Sep 2014 20:32:14 +0800
- Subject: Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain
- Authentication-results: sourceware.org; auth=none
- References: <1411691982-10744-1-git-send-email-palves at redhat dot com> <1411691982-10744-4-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> @@ -15496,22 +15466,9 @@ single_step_breakpoints_inserted (void)
> void
> remove_single_step_breakpoints (void)
> {
> - gdb_assert (single_step_breakpoints[0] != NULL);
> + gdb_assert (single_step_breakpoints != NULL);
>
> - /* See insert_single_step_breakpoint for more about this deprecated
> - call. */
> - deprecated_remove_raw_breakpoint (single_step_gdbarch[0],
> - single_step_breakpoints[0]);
> - single_step_gdbarch[0] = NULL;
> - single_step_breakpoints[0] = NULL;
> -
> - if (single_step_breakpoints[1] != NULL)
> - {
> - deprecated_remove_raw_breakpoint (single_step_gdbarch[1],
> - single_step_breakpoints[1]);
> - single_step_gdbarch[1] = NULL;
> - single_step_breakpoints[1] = NULL;
> - }
> + delete_breakpoint (single_step_breakpoints);
We need to set single_step_breakpoints back to NULL. This causes many
fails for arm-linux-gnueabi target, as I tested.
--
Yao (éå)