This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch, microblaze]: Port of Linux gdbserver
- From: Michael Eager <eager at eagercon dot com>
- To: Ajit Kumar Agarwal <ajit dot kumar dot agarwal at xilinx dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Vinod Kathail <vinodk at xilinx dot com>, Vidhumouli Hunsigida <vidhum at xilinx dot com>, Nagaraju Mekala <nmekala at xilinx dot com>
- Date: Wed, 10 Sep 2014 06:31:33 -0700
- Subject: Re: [Patch, microblaze]: Port of Linux gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a at BN1BFFO11FD002 dot protection dot gbl>
On 09/10/14 03:14, Ajit Kumar Agarwal wrote:
Please find the patch for the Linux gdbserver port for Microblaze.
[Patch, microblaze]: Port of Linux gdbserver
This patch is the port of Linux gdbserver.
ChangeLog:
2014-10-09 Ajit Agarwal <ajitkum@xilinx.com>
* microblaze-tdep.h (MICROBLAZE_BREAKPOINT): New Macro.
(MICROBLAZE_BREAKPOINT_LE): New Macro.
* microblaze-linux-tdep.c
(microblaze_linux_memory_remove_breakpoint): Use of
set_gdbarch_fetch_tls_load_module_address, do_cleanup.
* configure.host (microblaze): New.
(microblaze*-*-linux*): New.
* configure.tgt (build_gdbserver): New Definition.
* gdbserver/Makefile.in (microblaze-linux.c): New target.
* gdbserver/configure.srv (microblaze*-*-linux*): New target.
* gdbserver/linux-microblaze-low.c: New file.
Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
Thanks & Regards
Please follow GNU coding conventions:
+ if (microblaze_regmap[regno] == -1 || regno == 0)
+ return 1;
+
+ return 0;
No indent.
+/* dbtrap insn */
+/* brki r16, 0x18; */
Remove cruft.
+ if (regno == 0)
+ {
+ unsigned long regbuf_0 = 0;
+ /* Clobbering r0 so that it is always 0 as enforced by hardware. */
+ supply_register (regcache, regno, (const char*)®buf_0);
+ } else {
Indent.
+ for (i = 0; i < microblaze_num_regs; i++)
+ microblaze_collect_ptrace_register (regcache, i, (char *) buf + microblaze_regmap[i]);
Break lines before 80 cols.
+static struct regsets_info microblaze_regsets_info = {
+
+ microblaze_regsets, /* regsets */
+ 0, /* num_regsets */
+ NULL, /* disabled_regsets */
+};
Remove blank line.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077