This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>
- Date: Wed, 10 Sep 2014 11:39:43 +0100
- Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Authentication-results: sourceware.org; auth=none
- References: <1409320299-6812-1-git-send-email-gbenson at redhat dot com> <1409320299-6812-4-git-send-email-gbenson at redhat dot com>
On 08/29/2014 02:51 PM, Gary Benson wrote:
> This commit introduces two new functions to stop and restart target
> processes that shared code can use and that clients must implement.
> It also changes some shared code to use these functions.
>
> The changes in this patch replace the target_stop, target_wait
> and target_resume parts of this patch I posted on August 1:
> https://sourceware.org/ml/gdb-patches/2014-08/msg00014.html
> The remainder of that patch is in patch 2 of this series.
>
> gdb/ChangeLog:
>
> * target/target.h (target_stop_ptid, target_continue_ptid):
> Declare.
> * target.c (target_stop_ptid, target_continue_ptid): New
> functions.
> * common/agent.c [!GDBSERVER]: Don't include infrun.h.
> (agent_run_command): Always use target_stop_ptid and
> target_continue_ptid.
>
> gdb/gdbserver/ChangeLog:
>
> * target.c (target_stop_ptid, target_continue_ptid): New
> functions.
OK, with ...
> +/* Make target stop in a continuable fashion. (For instance, under
> + Unix, this should act like SIGSTOP). This function must be
> + provided by the client. This function is normally used by GUIs
> + to implement a stop button. */
... Please drop the last sentence referring to GUIs.
> +
> +extern void target_stop_ptid (ptid_t ptid);
Thanks,
Pedro Alves