This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] skip_prologue_using_sal: early exit if assembler
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 3 Sep 2014 09:55:32 -0700
- Subject: Re: [PATCH] skip_prologue_using_sal: early exit if assembler
- Authentication-results: sourceware.org; auth=none
- References: <yjt2vbp5pnje dot fsf at ruffy dot mtv dot corp dot google dot com>
On Tue, Sep 2, 2014 at 5:15 PM, Doug Evans <email@example.com> wrote:
> This patch is part of the discussion I started here:
> The prologue parsing aspect of that discussion is submitted
> as a patch here:
> This patch fixes a few failures when tested with clang,
> e.g. amd64-disp-step.exp. There's no point in trying to
> use source line info to parse prologues in assembler code.
> Regression tested on amd64, i386, aarch64, ppc64 [all linux].
> Note: Most of the patch is due to re-indentation.
> 2014-09-02 Doug Evans <firstname.lastname@example.org>
> * symtab.c (skip_prologue_using_sal): Return zero if called for
> assembler code.
btw, I think a case can be made to return func_addr here instead of zero.
IOW define things such that if we know we're in assembler there
is never any prologue (for symtab-and-line based prologue skipping).
If the caller wants to be "clever" for assembler they can do so.
And if ever someone wants symtab-and-line based prologue skipping
for assembler to detect and skip a prologue then
implement support for DW_LNS_set_prologue_end.
[And if a non-DWARF debug format doesn't support its equivalent, punt.]