This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/5] Make gdbserver use exceptions and cleanups
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 29 Aug 2014 11:07:10 +0100
- Subject: Re: [PATCH 0/5] Make gdbserver use exceptions and cleanups
- Authentication-results: sourceware.org; auth=none
- References: <1408351618-21013-1-git-send-email-gbenson at redhat dot com> <53FF4D37 dot 4080704 at redhat dot com>
Pedro Alves wrote:
> On 08/18/2014 09:46 AM, Gary Benson wrote:
> > gdbserver has the rudiments of an exception system, but it's
> > kind of hacky. This series converts gdbserver to use the
> > same exceptions and cleanups as GDB.
> >
> > This series is fairly minimal in that only the catch/cleanup code
> > in what was "main" has been updated to use the new system. Other
> > parts of gdbserver could likely be converted to TRY_CATCH and
> > cleanups too, but that can be done on an as-needed basis if this
> > patch is accepted.
> >
> > A side-effect of this patch is that some error messages will
> > change slightly, and in cases with multiple errors the error
> > messages will be printed in a different order.
> >
> > Built and regtested on RHEL 6.5 x86_64.
> >
> > Ok to commit?
>
> Other than the minor nits I just picked in the responses to the
> patches, this looks great to me.
>
> Thanks a lot for doing this.
No problem, thanks for the review :)
I've pushed this with the changes you suggested.
common-exceptions.h and cleanups.h are now included in server.h.
They're not global includes in GDB, but I could put together a
patch making them so if you like? Let me know...
Thanks,
Gary
--
http://gbenson.net/