This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] [PR symtab/17276]: Coalesce line number entries.
- From: Doug Evans <dje at google dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 27 Aug 2014 10:17:34 -0700
- Subject: Re: [PATCH 1/2] [PR symtab/17276]: Coalesce line number entries.
- Authentication-results: sourceware.org; auth=none
- References: <yjt2bnrlb65i dot fsf at ruffy dot mtv dot corp dot google dot com> <53FDDAE8 dot 2070700 at ericsson dot com>
Simon Marchi writes:
> > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> > index 801f05d..2017821 100644
> > --- a/gdb/dwarf2read.c
> > +++ b/gdb/dwarf2read.c
> > @@ -17172,6 +17172,32 @@ noop_record_line (struct subfile *subfile, int line, CORE_ADDR pc)
> > return;
> > }
> >
> > +/* Use P_RECORD_LINE to record line number LINE beginning at address ADDRESS
> > + in the line table of subfile SUBFILE. */
> > +
> > +static void
> > +dwarf_record_line (struct gdbarch *gdbarch, struct subfile *subfile,
> > + unsigned int line, CORE_ADDR address,
> > + record_line_ftype p_record_line)
> > +{
> > + CORE_ADDR addr = gdbarch_addr_bits_remove (gdbarch, address);
> > +
> > + (*p_record_line) (current_subfile, line, addr);
> ^^^^^^^^^^^^^^^
> I am pretty sure current_subfile here should be subfile.
Zoinks.
Thanks for catching that!
Fix pushed.