This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH OBV] set print symbol off in py-value.exp and scm-value.exp
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 22 Aug 2014 10:07:49 -0700
- Subject: Re: [PATCH OBV] set print symbol off in py-value.exp and scm-value.exp
- Authentication-results: sourceware.org; auth=none
- References: <1408714136-32131-1-git-send-email-yao at codesourcery dot com>
Yao Qi writes:
> 2014-08-22 Yao Qi <yao@codesourcery.com>
>
> * gdb.guile/scm-value.exp (test_lazy_strings): Set print
> symbol off.
> * gdb.python/py-value.exp (test_lazy_strings): Likewise.
> ---
> gdb/testsuite/gdb.guile/scm-value.exp | 2 ++
> gdb/testsuite/gdb.python/py-value.exp | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp
> index 91e1a56..3641f75 100644
> --- a/gdb/testsuite/gdb.guile/scm-value.exp
> +++ b/gdb/testsuite/gdb.guile/scm-value.exp
> @@ -219,6 +219,8 @@ proc test_lazy_strings {} {
> "= const char \*." "Test lazy-string type name equality"
> gdb_test "gu (print (value-type sptr))" \
> "= const char \*." "Test string type name equality"
> + # Prevent symbol on address 0x0 being printed.
> + gdb_test_no_output "set print symbol off"
> gdb_test "print sn" "0x0"
> gdb_scm_test_silent_cmd "gu (define snptr (history-ref 0))" \
> "lazy strings: get snptr value from history"
> diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp
> index 0728266..0d18bef 100644
> --- a/gdb/testsuite/gdb.python/py-value.exp
> +++ b/gdb/testsuite/gdb.python/py-value.exp
> @@ -302,7 +302,11 @@ proc test_lazy_strings {} {
> gdb_py_test_silent_cmd "python lstr = sptr.lazy_string()" "Aquire lazy string" 1
> gdb_test "python print (lstr.type)" "const char \*." "Test lazy-string type name equality"
> gdb_test "python print (sptr.type)" "const char \*." "Test string type name equality"
> +
> + # Prevent symbol on address 0x0 being printed.
> + gdb_test_no_output "set print symbol off"
> gdb_test "print sn" "0x0"
> +
> gdb_py_test_silent_cmd "python snptr = gdb.history (0)" "Get value from history" 1
> gdb_test "python snstr = snptr.lazy_string(length=5)" ".*Cannot create a lazy string with address.*" "Test lazy string"
> gdb_py_test_silent_cmd "python snstr = snptr.lazy_string(length=0)" "Succesfully create a lazy string" 1
Nit.
I like the blank lines added in py-value.exp.
I also like consistency. :-)
Please add them to scm-value.exp too.