This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PUSHED] Remove useless gcore command detection (was: Re: [patch+7.8?] Fix 'gcore' with exited threads)
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 21 Aug 2014 20:29:04 +0200
- Subject: Re: [PUSHED] Remove useless gcore command detection (was: Re: [patch+7.8?] Fix 'gcore' with exited threads)
- Authentication-results: sourceware.org; auth=none
- References: <20140609203020 dot GA22447 at host2 dot jankratochvil dot net> <53A8427D dot 6070902 at redhat dot com> <20140817211647 dot GA17152 at host2 dot jankratochvil dot net> <53F5CCC8 dot 3010903 at redhat dot com>
On Thu, 21 Aug 2014 12:41:12 +0200, Pedro Alves wrote:
> On 08/17/2014 10:16 PM, Jan Kratochvil wrote:
> >> > I believe this is is stale -- gcore.o has been in COMMON_OBS for a while
> >> > now. I think the actual error will be whatever the default for the target
> >> > method throws.
> > Likewise two paragraphs above. Not sure what I should do with it:
> > * If I remove the test from this my testcase and someone later fixes
> > the 6 existing instances of this test this only test will remain unfixed.
> > * If I waste the time reading the sources what should be the expected output
> > I risk the test will not work anyway as I read it wrongly.
> > And I will probably wrongly modify 6 other testsuite cases.
> > * I can try to find a platform without gcore but in most cases in the past my
> > attempts to build GDB on any non-Linux platforms failed.
>
> No no, you misunderstand, we should just delete it completely.
> It's a useless test. See patch below.
I understood it perfectly. I just did not want to invest time into writing
the off-topic patch and writing its ChangeLog for the patch you wrote below.
It is now solved and I can remove the gcore test also from my patch, thanks.
Jan