This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4 v6] Introduce common-debug.h
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>, Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 20 Aug 2014 16:51:16 +0100
- Subject: Re: [PATCH 4/4 v6] Introduce common-debug.h
- Authentication-results: sourceware.org; auth=none
- References: <1407770255-2589-1-git-send-email-gbenson at redhat dot com> <1407770255-2589-5-git-send-email-gbenson at redhat dot com> <21482 dot 43213 dot 338533 dot 34714 at ruffy dot mtv dot corp dot google dot com>
On 08/13/2014 12:52 AM, Doug Evans wrote:
> btw, it's confusing that the variable is named "debug_hw_points"
> but the command to set it is "maint set show-debug-regs". Bleah.
> The intuitive naming is to base the variable name off of the parameter name,
> but I'm also ok with changing the parameter name.
> "set debug hw-points <n>" ?
> I don't have a strong opinion, other than if we're making changes
> in this area IWBN to clean up the naming while we're at it.
> Plus "set debug ..." is more consistent with other such parameters
> than "maint set ...".
FWIW, if I don't use this command for a while, when I need it again,
I always get confused with the set+show in "maint SET SHOW-debug-regs".
I'd +1 renaming it to "set debug something".
(TBC, I'm not suggesting that doing this now.)
Thanks,
Pedro Alves