This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: --with-babeltrace generates many FAILs
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 19 Aug 2014 16:07:55 +0200
- Subject: Re: --with-babeltrace generates many FAILs
- Authentication-results: sourceware.org; auth=none
- References: <20140816204614 dot GA7000 at host2 dot jankratochvil dot net> <53F3457E dot 5030205 at codesourcery dot com>
On Tue, 19 Aug 2014 14:39:26 +0200, Yao Qi wrote:
> I can reproduce it on my Fedora 20 x86 machine. Let me know it
> works for you or not.
Yes, it works for me (Fedora 21pre x86_64).
Just suggesting:
* '#if HAVE_LIBBABELTRACE1_1_0' could have a comment that >=1.1.1 rejects the
faked packet (what you described in the mail but not in the patch).
* It is always better to check for feature/defect than to check for version.
For example because various distros backport various fixes (unfortunately
including their possible regressions/defects) and so version checks may be
misleading then. At least in this case it seems to me as possible to check
how libbacktrace behaves from configure; although maybe it is not easy
enough, not sure.
Thanks,
Jan