This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5 v7] Introduce common/errors.h
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Mon, 18 Aug 2014 09:20:42 -0700
- Subject: Re: [PATCH 1/5 v7] Introduce common/errors.h
- Authentication-results: sourceware.org; auth=none
- References: <1407923779-22149-1-git-send-email-gbenson at redhat dot com> <1407923779-22149-2-git-send-email-gbenson at redhat dot com>
On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson <gbenson@redhat.com> wrote:
> This introduces common/errors.h. This holds some error- and warning-
> related declarations that can be used by the code in common, nat and
> target. Some of the declared functions must be provided by the client
> as documented by the header file comments.
>
> gdb/
> 2014-08-13 Tom Tromey <tromey@redhat.com>
> Gary Benson <gbenson@redhat.com>
>
> * common/errors.h: New file.
> * common/errors.c: Likewise.
> * Makefile.in (SFILES): Add common/errors.c.
> (HFILES_NO_SRCDIR): Add common/errors.h.
> (COMMON_OBS): Add errors.o.
> (errors.o): New rule.
> * common/common-defs.h: Include errors.h.
> * utils.h (perror_with_name, error, verror, warning, vwarning):
> Don't declare.
> * common/common-utils.h: (malloc_failure, internal_error):
> Likewise.
>
> gdb/gdbserver/
> 2014-08-13 Tom Tromey <tromey@redhat.com>
> Gary Benson <gbenson@redhat.com>
>
> * Makefile.in (SFILES): Add common/errors.c.
> (OBS): Add errors.o.
> (IPA_OBS): Add errors-ipa.o.
> (errors.o): New rule.
> (errors-ipa.o): Likewise.
> * utils.h (perror_with_name, error, warning): Don't declare.
> * utils.c (warning): Renamed and rewritten as...
> (vwarning): New function.
> (error): Renamed and rewritten as...
> (verror): New function.
> (internal_error): Renamed and rewritten as...
> (internal_verror): New function.
LGTM