This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 4/6] Convert fatal to error in remote_prepare
- From: Gary Benson <gbenson at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 6 Aug 2014 16:58:06 +0100
- Subject: [PATCH 4/6] Convert fatal to error in remote_prepare
- Authentication-results: sourceware.org; auth=none
- References: <1407340688-13721-1-git-send-email-gbenson at redhat dot com>
This commit converts a call to fatal in remote_prepare with a call to
error. remote_prepare is called precisely once, from main, at a point
where jumping to toplevel will call exit (1), so error and fatal are
functionally equivalent at this point. Note that remote_prepare calls
perror_with_name (which calls error) so callers of remote_prepare must
already handle the fact that it may exit via longjmp.
gdb/gdbserver/
2014-08-06 Gary Benson <gbenson@redhat.com>
* remote-utils.c (remote_prepare): Replace fatal with error.
---
gdb/gdbserver/ChangeLog | 4 ++++
gdb/gdbserver/remote-utils.c | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 4fcafa0..027d2a7 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -253,7 +253,7 @@ remote_prepare (char *name)
port = strtoul (port_str + 1, &port_end, 10);
if (port_str[1] == '\0' || *port_end != '\0')
- fatal ("Bad port argument: %s", name);
+ error ("Bad port argument: %s", name);
#ifdef USE_WIN32API
if (!winsock_initialized)
--
1.7.1