This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 0/8] Error handling cleanups
- From: Gary Benson <gbenson at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 6 Aug 2014 11:12:20 +0100
- Subject: [PATCH 0/8] Error handling cleanups
- Authentication-results: sourceware.org; auth=none
Hi all,
GDB's various error handling functions do not work until a certain
amount of setup has been performed. For regular warnings and errors
this is an annoyance: error handling needs to be hardwired with
fprintf and/or exit until error and warning may be called. For
internal warnings and errors this is a real problem: internal errors
can occur from almost the first line of captured_main, but they don't
actually work until much later.
This series modifies internal_vproblem to always work, and modifies
warning and error to work much earlier. It then replaces all the
hardwired early warning/error code with standard calls to warning and
error.
While looking at this I found several other hardwired error handlers
that do not seem to be necessary. I've replaced those in separate
patches.
While switching to warning/error I've fixed some inconsistencies that
have crept in over time: some messages wern't wrapped with _(), for
example, and some but not all warning messages were prefixed with
argv[0]. For the latter case I've made it so that all warnings
emitted prior to and during option processing--before print_gdb_version
basically--are prefixed by argv[0] and all other warnings are not.
Built and regtested on RHEL6.5 x86_64.
Ok to commit?
Thanks,
Gary