[PATCH 00/11 v5] Common code cleanups

[Gary Benson <gbenson at redhat dot com>]

Hi all,

This series contains updated versions of the common code cleanups
patches I've posted previously.  These have been reworked (in some
cases recreated) to apply on top of my "Include some headers in
common-defs.h" series that is currently under review [1, 2].

Current gdb/master has 32 uses of "#ifdef GDBSERVER".  This series
reduces that count to three:

  - One in common/common-defs.h, to select the appropriate gnulib
    config.h.  This use can be removed when the build is modified
    to build only one copy of gnulib.

  - One in common/common-types.h, to define types based on BFD's
    types (for GDB) or otherwise (for gdbserver).  I'm not sure
    what form removing this use would take.

  - One in linux-waitpid.c to protect some gdbserver-specific
    thread debugging code which can be removed when the Linux
    thread_db code is unified and made shared.

All built and regtested on x86-64 RHEL6.5.  mips-linux-watch.h
changes checked by cross-building gdbserver with the Sourcery
CodeBench for MIPS GNU/Linux toolchain.

If this series is approved I will update the "Include Files" section
of the Coding Standards page [3] to insert the following line after
the existing first line:

  "All .c files under gdb/common/, gdb/nat/ and gdb/target/ must
  include common-defs.h as their first non-comment line."

I will also update the subsequent mentions of common-defs.h
accordingly.

Is this ok to commit?

Thanks,
Gary

--
[1] https://sourceware.org/ml/gdb-patches/2014-07/msg00736.html
[2] https://sourceware.org/ml/gdb-patches/2014-07/msg00820.html
[3] https://sourceware.org/gdb/wiki/Internals GDB-C-Coding-Standards