This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Do not include config.h directly
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 29 Jul 2014 16:03:09 +0100
- Subject: Re: [PATCH 2/3] Do not include config.h directly
- Authentication-results: sourceware.org; auth=none
- References: <1406295265-4681-1-git-send-email-gbenson at redhat dot com> <1406295265-4681-3-git-send-email-gbenson at redhat dot com>
On 07/25/2014 02:34 PM, Gary Benson wrote:
> All source files under gdb/ that include headers from gdb/ include
> either defs.h or server.h before any other code
> with the exception
> of gdb/gdbserver/gdbreplay.c which seems to be a special case.
gdbreplay is simply another program that lives in the
gdbserver directory too, for historical reasons.
> Both
> defs.h and server.h include both our and gnulib's config.h files as
> their first non-comment line, so no other file ever needs to directly
> include any config.h. This commit removes two such direct config.h
> includes.
>
Looks good.
Thanks,
Pedro Alves