This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Make all source files include defs.h or server.h first
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 29 Jul 2014 15:59:27 +0100
- Subject: Re: [PATCH 1/3] Make all source files include defs.h or server.h first
- Authentication-results: sourceware.org; auth=none
- References: <1406295265-4681-1-git-send-email-gbenson at redhat dot com> <1406295265-4681-2-git-send-email-gbenson at redhat dot com>
On 07/25/2014 02:34 PM, Gary Benson wrote:
> This commit makes all source files under gdb/ that include headers
> from gdb/ include either defs.h or server.h before any other code.
> This ensures that definitions and macros from the two config.h files
> are always in place for our code. An exception has been made for
> gdb/gdbserver/gdbreplay.c which seems to be a special case.
>
> gdb/
> 2014-07-25 Gary Benson <gbenson@redhat.com>
>
> * btrace.c: Include defs.h.
> * common/ptid.c: Include defs.h or server.h as appropriate.
> * nat/mips-linux-watch.c: Likewise.
>
> gdb/gdbserver/
> 2014-07-25 Gary Benson <gbenson@redhat.com>
>
> * hostio-errno.c: Move server.h to top of includes list.
> * inferiors.c: Likewise.
> * linux-x86-low.c: Likewise.
> * notif.c: Include server.h.
Looks good to me.
Thanks,
Pedro Alves