This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] simplify target_is_pushed
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 29 Jul 2014 05:47:16 -0700
- Subject: Re: [PATCH 2/4] simplify target_is_pushed
- Authentication-results: sourceware.org; auth=none
- References: <1405711635-1102-1-git-send-email-tromey at redhat dot com> <1405711635-1102-3-git-send-email-tromey at redhat dot com>
> While working on target_is_pushed, I noticed that it is written in a
> strange way. The code currently keeps an extra indirection, where a
> simple linked list traversal is all that is needed. It seems likely
> this was done by copying and pasting other code. However, there is no
> reason to do this and the more obvious code is simpler to reason
> about. So, this patch change the implementation.
>
> 2014-07-18 Tom Tromey <tromey@redhat.com>
>
> * target.c (target_is_pushed): Simplify.
Indeed. It looks like this one could go in on its own...
--
Joel