This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
- From: Pedro Alves <palves at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>, gdb-patches at sourceware dot org
- Cc: Yao Qi <yao at codesourcery dot com>
- Date: Tue, 29 Jul 2014 13:40:01 +0100
- Subject: Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1407231515400 dot 16254 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1407231529220 dot 16254 at tp dot orcam dot me dot uk>
Looks good to me.
I wonder though, whether:
On 07/24/2014 11:39 PM, Maciej W. Rozycki wrote:
> +set savedtimeout $timeout
> +if { [target_info exists gdb,timeout]
> + && $timeout < [target_info gdb,timeout] } {
> + set oldtimeout [target_info gdb,timeout]
> +} else {
> + set oldtimeout $timeout
> +}
> +set timeout [expr $oldtimeout * 2]
... this pattern can be somewhat factored into a
procedure? That'd also serve the duty of being the
simple place we document it.
> gdb_test "continue" "\[process \[0-9\]+ .*" "continue to signal exit" \
Thanks,
Pedro Alves