Re: [PATCH 1/2] GDB/testsuite: Avoid timeout lowering

[Pedro Alves <palves at redhat dot com>]

On 07/25/2014 02:37 AM, Yao Qi wrote:
> On 07/25/2014 06:38 AM, Maciej W. Rozycki wrote:
>>  With the timeout selection code from gdb_test_multiple gone, gone is also 
>> the most prominent use of this timeout argument, it's now used in a couple 
>> of places only, mostly within this test framework library code itself for 
>> preparatory commands or suchlike.  With this being the case this timeout 
>> selection code can be simplified as follows:
>>
>> 1. Among the three timeout variables, the highest is always chosen.  This 
>>    is so that a test case doesn't inadvertently lower a high value timeout 
>>    needed by slow target boards.  This is what all test cases use.
>>
>> 2. Any timeout argument takes precedence.  This is for special cases such 
>>    as within the framework library code, e.g. it doesn't make sense to 
>>    send `set height 0' with a timeout of 7200 seconds.  This is a local 
>>    command that does not interact with the target and setting a high 
>>    timeout here only risks a test suite run taking ages if it goes astray 
>>    for some reason.

Indeed.  It feels like a host vs target timeout concept.  That is, we
can still have a slow remote host, but that's a different vector of
slow vs a slow target.

>>
>> 3. The fallback timeout of 60s remains.
> 
> Maciej,
> IWBN to put the descriptions about timeout selection into the comments
> of proc gdb_expect.

Agreed.  Or even somewhere more central, and have gdb_expect
gdb_test_multiple, etc. refer to that.

> I don't see anything wrong in this patch.

Me neither.

Thanks,
Pedro Alves