This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Update comments to operator_check
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Tue, 29 Jul 2014 13:18:27 +0100
- Subject: Re: [PATCH] Update comments to operator_check
- Authentication-results: sourceware.org; auth=none
- References: <1406288349-17116-1-git-send-email-yao at codesourcery dot com>
On 07/25/2014 12:39 PM, Yao Qi wrote:
> Hello,
> I happen to read the code and find the comments to operator_check are
> incorrect. This patch is to fix the comments per my understanding.
> The comments and field operator_check was added by this patch
>
> https://sourceware.org/ml/gdb-patches/2010-04/msg00556.html
>
> but the inconsistency between code and comments wasn't pointed out during
> the review.
Yeah, IIUC, that code was originally based on:
https://sourceware.org/ml/gdb-patches/2009-07/msg00054.html
>
> gdb:
>
> 2014-07-25 Yao Qi <yao@codesourcery.com>
>
> * parser-defs.h (struct exp_descriptor) <operator_check>: Update
> comments.
> * parse.c (exp_iterate): Update comments.
OK.
--
Thanks,
Pedro Alves