This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] mi-out: Implement mi redirection using a stack.
- From: Tom Tromey <tromey at redhat dot com>
- To: Adrian Sendroiu <adrian dot sendroiu at freescale dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 24 Jul 2014 12:19:05 -0600
- Subject: Re: [PATCH 2/2] mi-out: Implement mi redirection using a stack.
- Authentication-results: sourceware.org; auth=none
- References: <1406125575-28311-1-git-send-email-adrian dot sendroiu at freescale dot com> <1406125575-28311-3-git-send-email-adrian dot sendroiu at freescale dot com>
>>>>> "Adrian" == Adrian Sendroiu <adrian.sendroiu@freescale.com> writes:
Adrian> gdb/
Adrian> 2014-07-23 Adrian Sendroiu <adrian.sendroiu@freescale.com>
Adrian> * mi/mi-out.c (ui_filep): New typedef.
[...]
I think it would be good to have some text in the message describing the
rationale for this patch.
One nit below.
Adrian> /* FIXME: This code should be using a ``string_file'' and not the
Adrian> TUI buffer hack. */
Not your problem but I wonder what this FIXME comment means.
I suspect it's obsolete since as far as I know mem_fileopen does return
a "string_file".
Adrian> + new_stream = mem_fileopen();
Space before the open paren.
The patch is ok with this fixed and with some rationale text.
thanks,
Tom