This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix to_open debug setting
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 24 Jul 2014 02:07:30 +0100
- Subject: Re: [PATCH] fix to_open debug setting
- Authentication-results: sourceware.org; auth=none
- References: <1405975154-19517-1-git-send-email-tromey at redhat dot com> <87ha2as33y dot fsf at fleche dot redhat dot com> <87d2cxs9bu dot fsf at fleche dot redhat dot com>
On 07/22/2014 04:27 PM, Tom Tromey wrote:
> Tom> Later I happened to notice that add_deprecated_target_alias could use
> Tom> the same treatment. I'll send the new patch tomorrow.
>
> Here it is.
Looks good to me.
> +/* This is used to implement the various target commands. */
> +
> +static void
> +open_target (char *args, int from_tty, struct cmd_list_element *command)
> +{
> + struct target_ops *ops = get_cmd_context (command);
> +
> + if (targetdebug)
> + fprintf_unfiltered (gdb_stdlog, "target_open (%s, %d)\n", args, from_tty);
I think it'd be nice if this included the target's name, like your
generated debug methods.
Thanks,
--
Pedro Alves