This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 15 Jul 2014 21:56:41 +0800
- Subject: Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode
- Authentication-results: sourceware.org; auth=none
- References: <1404100222-2312-1-git-send-email-yao at codesourcery dot com> <53BD5710 dot 5040105 at redhat dot com> <53BDEBD8 dot 5030201 at codesourcery dot com> <53C52622 dot 3000405 at redhat dot com>
On 07/15/2014 09:01 PM, Pedro Alves wrote:
> While doing
> that I noticed that write_error_trace_file needs the Thumb
> treatment too?
>
Yes, that is correct.
> WDYT of the patch below? I don't think we need to worry about
> targets that don't have stdint.h in this test and at this
> day and age.
The patch looks good to me. Thanks.
> The rest is just enough changes to make the file build without
> warnings with "-Wall -Wextra" with x86_64-w64-mingw32-gcc and
> i686-w64-mingw32-gcc cross compilers, and with -m32/-m64 on x86_64
> GNU/Linux. Currently with x86_64-w64-mingw32-gcc we get:
Make sure I understand you correctly, you fixed warnings on mingw32 but
didn't run the test on mingw32, did you?
--
Yao (éå)