This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 04/12] record btrace: add configuration struct
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: palves at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 14 Jul 2014 17:55:29 +0300
- Subject: Re: [PATCH 04/12] record btrace: add configuration struct
- Authentication-results: sourceware.org; auth=none
- References: <1405346196-1804-1-git-send-email-markus dot t dot metzger at intel dot com> <1405346196-1804-5-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 14 Jul 2014 15:56:28 +0200
>
> Add a struct to describe the branch trace configuration and use it for
> enabling branch tracing.
>
> The user will be able to set configuration fields for each tracing format
> to be used for new threads.
Thanks.
> diff --git a/gdb/NEWS b/gdb/NEWS
> index d9a19ae..f32d1ef 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,17 @@
>
> *** Changes since GDB 7.8
>
> +* New commands (for set/show, see "New options" below)
> +
> +record btrace bts
> +record bts
> + Start branch trace recording using Intel(R) Branch Trace Store format.
> +
> +* New remote packets
> +
> +qXfer:btrace-conf:read
> + Return the branch trace configuration for the current thread.
> +
> *** Changes in GDB 7.8
This part is OK.
> +@table @code
> +@item bts
> +Use Intel's Branch Trace Store (BTS) recording format. In this format,
Suggest to put "Branch Trace Store" in @dfn and "BTS" in @acronym,
this will look better in print.
Also, there should be @cindex entries for these 2 terms.
The documentation parts are OK with those changes.