This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
- From: Gary Benson <gbenson at redhat dot com>
- To: Corinna Vinschen <vinschen at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, Andrew Burgess <aburgess at broadcom dot com>, Doug Evans <xdje42 at gmail dot com>, Eli Zaretskii <eliz at gnu dot org>, Florian Weimer <fw at deneb dot enyo dot de>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Mon, 14 Jul 2014 13:02:57 +0100
- Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140609152229 dot GA27494 at blade dot nx> <20140609152434 dot GD27494 at blade dot nx> <000901cf9eb5$16841da0$438c58e0$ at muller@ics-cnrs.unistra.fr> <20140714083643 dot GA10872 at calimero dot vinschen dot de>
Corinna Vinschen wrote:
> On Jul 13 18:11, Pierre Muller wrote:
> > A simple patch would probably be to add a separate check
> > #ifdef SA_ONSTACK
> > sa.sa_flags = SA_O?STACK;
> > #endif
>
> Right, Cygwin doesn't support SA_ONSTACK yet. It should be
> possible to add, but there are no immediate plans to do so.
>
> As for the above, wouldn't it be better to add something like
>
> #ifndef SA_ONSTACK
> #define SA_ONSTACK 0
> #endif
>
> to some header?
I'd prefer not to. Having the conditional where the handler
is installed makes it obvious that the alternate stack is not
available on all systems.
Thanks,
Gary
--
http://gbenson.net/