This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Fri, 11 Jul 2014 12:28:18 +0100
- Subject: Re: [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c
- Authentication-results: sourceware.org; auth=none
- References: <1403878351-22974-1-git-send-email-gbenson at redhat dot com> <53BD40E6 dot 8000701 at redhat dot com>
Pedro Alves wrote:
> On 06/27/2014 03:12 PM, Gary Benson wrote:
> > This series is an updated version of the series I posted this
> > morning. Mark Kettenis rightly pointed out that
> > x86_linux_read_description was a mess of #ifdef spaghetti so
> > I have rewritten it.
> >
> > Patch 2 has changed because that's where the
> > x86_linux_read_description merge is. Patch 6 has changed because
> > that's where the code is pulled from {i386,amd64}-linux-nat.c into
> > x86-linux-nat.c. The remaining patches are the same.
> >
> > I've inlined the original description of the series below.
> >
> > Is this ok to commit?
>
> I read this, and apart from a couple nits, it all looked good to me.
>
> I think we can take Mark's silence as meaning his objections have
> been addressed, but in case he just didn't have time to reply, let's
> wait till Friday, and then push this in.
Pushed with the changes you suggested.
Thanks,
Gary
--
http://gbenson.net/