Re: [PATCH 5/9] Canceling pagination caused by execution command from command line aborts readline/gdb

[Yao Qi <yao at codesourcery dot com>]

On 07/10/2014 12:45 AM, Pedro Alves wrote:
> Looks like we already have a ton of tests using sleep/usleep,
> so such a fix would best be done across the board.  Perhaps
> even by adding a sleep.h header to testsuite/lib/ or some such ?
> Or if not needed with newer toolchains, just ignore it.  :-)

Yes, sleep has been widely used in the testsuite, but some of these
tests are not really compiled nor executed on mingw.  I'll take a
look if it makes trouble, but I am fine to ignore it at current stage.

> 
>>> >> +proc probe_can_run_cmdline  {} {
>>> >> +    global srcfile binfile
>>> >> +    global saved_gdbflags GDBFLAGS
>>> >> +    global gdb_prompt
>>> >> +
>>> >> +    set GDBFLAGS $saved_gdbflags
>>> >> +    append GDBFLAGS " -ex \"set height 0\""
>>> >> +    append GDBFLAGS " -ex \"start\""
>>> >> +    append GDBFLAGS " --args \"$binfile\""
>> > 
>> > This doesn't work on remote host, as we haven't copy binfile from build
>> > to host yet.  We can do this after build_executable, and pass $file_arg
>> > to each proc instead of using $binfile in each proc.
> Thanks.  See the new version below.

It looks good to me.  I don't have other comments.

-- 
Yao (éå)