This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7 v2] Rename identical functions
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, Pedro Alves <palves at redhat dot com>
- Date: Wed, 09 Jul 2014 14:04:30 +0100
- Subject: Re: [PATCH 1/7 v2] Rename identical functions
- Authentication-results: sourceware.org; auth=none
- References: <1403878351-22974-1-git-send-email-gbenson at redhat dot com> <1403878351-22974-2-git-send-email-gbenson at redhat dot com>
On 06/27/2014 03:12 PM, Gary Benson wrote:
> amd64-linux-nat.c and i386-linux-nat.c contain a number of functions
> which are identical but for prefix on their names. This commit
> renames all such functions to have the prefix x86_ instead of the
> prefixes amd64_ or i386_ and updates all uses of those functions.
>
> This patch is unchanged from the original version in this series.
Looks good to me. It's worth mentioning that the x86_ functions
will be pulled out to a separate and shared x86-* file in a later
patch in the series.
--
Pedro Alves