Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

> From: Gary Benson <gbenson@redhat.com>
> Date: Fri, 27 Jun 2014 10:10:02 +0100
> 
> Hi all,
> 
> This series refactors the shared code in {i386,amd64}-linux-nat.c into
> the new files x86-linux-nat.[ch] and i386-linux-nat.h.  The first five
> patches remove spurious changes between the files so that the code to
> be shared is identical:
> 
>   1/7 - Rename identical functions
>   2/7 - Merge {i386,amd64}_linux_read_description
>   3/7 - Merge ps_get_thread_area
>   4/7 - Pull out common parts of _initialize_{i386,amd64}_linux_nat
>   5/7 - Comment and whitespace changes
> 
> The sixth patch moves the shared code into the new files and does all
> the makefile and build system updates:
> 
>   6/7 - Move duplicated code into new files
> 
> The seventh patch tidies the blocks of #include directives at the
> tops of {i386,amd64}-linux-nat.c:
> 
>   7/7 - Tidy #include lists
> 
> This final patch is not strictly necessary for the series, but it
> makes things tidier.
> 
> Is this ok to commit?

Sorry, no.  Perhaps more code can be shared between i386-linux-nat.c
and amd64-linux-nat.c, but this goes too far and turns things into
#ifdef spagetthi.  It also breaks established naming conventions.