This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: gbenson at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 Jun 2014 11:21:25 +0200 (CEST)
- Subject: Re: [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat
- Authentication-results: sourceware.org; auth=none
- References: <1403860209-475-1-git-send-email-gbenson at redhat dot com> <1403860209-475-5-git-send-email-gbenson at redhat dot com>
> From: Gary Benson <gbenson@redhat.com>
> Date: Fri, 27 Jun 2014 10:10:06 +0100
>
> This commit adds two new helpers, x86_linux_create_target
> and x86_linux_register_target, to hold the parts of
> _initialize_i386_linux_nat and _initialize_amd64_linux_nat
> which are common.
Please stick to the existing naming convention. Functions in i386-*.c
start with i386_, functions in amd64-*.c start with amd64_.
>
> gdb/
> 2014-06-27 Gary Benson <gbenson@redhat.com>
>
> * amd64-linux-nat.c (x86_linux_create_target): New function.
> (x86_linux_register_target): Likewise.
> (_initialize_amd64_linux_nat): Delegate to the above new functions.
> * i386-linux-nat.c (x86_linux_create_target): New function.
> (x86_linux_register_target): Likewise.
> (_initialize_i386_linux_nat): Delegate to the above new functions.