This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [Patch]Clean up the XML files for ARM
- From: "Terry Guo" <terry dot guo at arm dot com>
- To: "'Pedro Alves'" <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 25 Jun 2014 09:29:44 +0800
- Subject: RE: [Patch]Clean up the XML files for ARM
- Authentication-results: sourceware.org; auth=none
- References: <000b01cf8540$dafa6d80$90ef4880$ at arm dot com> <CANu=Dmj+bns6TtgSULCBy-5_+iLGPgY0aXOPD0pmQgSMbRuJ7g at mail dot gmail dot com> <001701cf8555$40925540$c1b6ffc0$ at arm dot com> <53983C82 dot 4040208 at codesourcery dot com> <001801cf85ef$f9decd40$ed9c67c0$ at arm dot com> <000001cf8908$49f991f0$ddecb5d0$ at arm dot com> <CANu=Dmg7gXZtmKA9Du=ZsYuStpKMJRe+Bypu+MQkn-XDAn52xA at mail dot gmail dot com> <001501cf8c34$7336e840$59a4b8c0$ at arm dot com> <53A40465 dot 70508 at redhat dot com> <001c01cf8c71$6e7295b0$4b57c110$ at arm dot com> <53A41949 dot 70005 at redhat dot com> <002601cf8dd3$6ee6f780$4cb4e680$ at arm dot com> <53A8205C dot 50201 at redhat dot com>
osing the prefix in the generated code is problematic for multi-arch (--
> enable-target=all) builds, because this way we're open for conflict between
> archs. E.g., say we have
>
> arch1/linux.xml
> arch1/linux.c
> arch2/linux.xml
> arch2/linux.c
>
> Then we end up with multiple conflicting definitions of "struct target_desc
> *tdesc_linux;"
>
> I think we should fix this by making the directory name be a prefix in the
> generated code. That is, in the ARM case, these hunks would disappear from
> your patch:
>
> > -struct target_desc *tdesc_arm_with_m_vfp_d16;
> > +struct target_desc *tdesc_with_m_vfp_d16;
> > static void
> > -initialize_tdesc_arm_with_m_vfp_d16 (void)
> > +initialize_tdesc_with_m_vfp_d16 (void)
> > {
>
> Would you like to work on this?
>
> --
> Pedro Alves
>
You are right. I will work on this.
BR,
Terry