Re: [RFC] auto-generate most target debug methods

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This function should be renamed to target_debug_print_signal, for
Yao> example, and typedef unsigned char * signal, if I understand your
Yao> script correctly.

Yeah, that would be cleaner.  I'll fix it up.

>> +   A few methods are still handled explicitly in target.c:
>> +   target_fetch_registers target_store_registers target_xfer_partial

Yao> This isn't valid to me.  I do see debug_fetch_registers,
Yao> debug_store_registers and debug_xfer_partial are generated.

The comment is a bit off.

target_store_registers still has some targetdebug code to call
debug_print_register, which can't really be handled using the type-based
method.

to_xfer_partial has a debug method generated but due to the way
target_xfer_partial is written, the debug method is never actually
called.  Note that a similar issue exists in the current code with
debug_to_open -- I think it can't ever be called because the target's
to_open is passed directly to add_cmd.

Tom