This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 04/15] Comment changes
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Jun 2014 18:11:53 +0100
- Subject: Re: [PATCH 04/15] Comment changes
- Authentication-results: sourceware.org; auth=none
- References: <1403014378-4349-1-git-send-email-gbenson at redhat dot com> <1403014378-4349-5-git-send-email-gbenson at redhat dot com> <53A062B1 dot 5060005 at redhat dot com> <20140617160958 dot GA6680 at blade dot nx>
On 06/17/2014 05:09 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> On 06/17/2014 03:12 PM, Gary Benson wrote:
>>> This commit fixes various whitespace differences between
>>
>> s/whitespace/comment/
>
> Oops :)
>
>>> /* In non-stop/async, threads can be running while we change the
>>> - STATE (and friends). Say, we set a watchpoint, and let threads
>>
>>> + global dr_mirror (and friends). Say, we set a watchpoint, and
>>> + let threads resume. Now, say you delete the watchpoint, or
>>
>> Wrong direction, here, I'm afraid. There's no _global_ dr_mirror
>> anymore. There used to be one, before multi-process.
>
> Is s/global dr_mirror/dr_mirror/ ok, or something else?
Hmm, you know what, neither version is strictly correct.
"the STATE (and friends)" was clearly a blind search&replace.
So, to makes things easy, and avoid a potentially make-work
rebase, just leave it as you had it, and we can clean it
up afterwards.
--
Pedro Alves