Re: [PATCH] PR remote/17028: GDB+GDBserver hangs on Windows

[Joel Brobecker <brobecker at adacore dot com>]

> Here's my current patch to fix PR remote/17028.
> 
> It fixes the testcase in the PR for me, but I'm not set up
> for any sort of automated testing on Windows...

Thanks a lot for the patch. It looks pretty good to me, and it also
passed testing with our testsuite.

> I'd push this to my github for easier fetching, but github
> seems to be busted atm...

I know you were able to push it, but patches sent via git-send-email
are fine as far as I am concerned. I find it faster to apply via
git-am, for instance.

> However, on the GDBserver side, we that GDBserver already sent a T05
                                   ^^^ see?

> Now GDB does it's thing and goes back to the event loop.  That calls
               ^^^ its

> gdb/
> 2014-06-10  Pedro Alves  <palves@redhat.com>
> 
> 	PR remote/17028
> 	* ser-mingw.c (net_windows_socket_check_pending): New function.
> 	(net_windows_select_thread): Ignore spurious wakeups.  Use
> 	net_windows_socket_check_pending.
> 	(net_windows_wait_handle): Check for pending events with
> 	ioctlsocket, through net_windows_socket_check_pending, instead of
> 	checking the socket's event.

Thank you!
-- 
Joel