This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add Frame.read_register to Python API
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Alexander Smundak <asmundak at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 09 Jun 2014 22:25:57 +0300
- Subject: Re: [PATCH] Add Frame.read_register to Python API
- Authentication-results: sourceware.org; auth=none
- References: <CAHQ51u4gJRVFXNnUykc6EmCCFGd4O3+LJmpjFGMZ9AeQSvQCuQ at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 9 Jun 2014 12:15:26 -0700
> From: Alexander Smundak <asmundak@google.com>
>
> 2014-06-09 Sasha Smundak <asmundak@google.com>
>
> * python.texi (Writing a Frame Filter): Fix example code.
> (Frames in Python): Add read_register description.
> (Frames in Python): Fix reference in find_sal description.
When 2 changes are in the same node, write them one after the other,
and have only one "(Node Name)" thing.
> +* Python Scripting
> + Access frame registers
This is an incomplete sentence. I guess you meant something like
You can now access frame registers from Python scripts.
> +Return the value of @var{register} in this frame. The @var{register}
> +argument must be a string (e.g., 'rsp' or 'r1'), or a register number.
^^^^^^^^^^^^^
These should be in @code instead of quotes.
> +Returns @code{Gdb.Value} object.
^
"a" missing here.
The documentation parts are OK with these fixed.