This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/3 v4] Demangler crash handler
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Andrew Burgess <aburgess at broadcom dot com>, Eli Zaretskii <eliz at gnu dot org>, Florian Weimer <fw at deneb dot enyo dot de>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Fri, 6 Jun 2014 10:18:55 +0100
- Subject: Re: [PATCH 0/3 v4] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140605130140 dot GA20572 at blade dot nx> <CAP9bCMRFjiVf_t4zQ79tfMpvjY+YuD59__pXgEcgSDHFeEzvbg at mail dot gmail dot com>
Doug Evans wrote:
> On Thu, Jun 5, 2014 at 6:01 AM, Gary Benson <gbenson@redhat.com> wrote:
> > Doug requested that I change the patch to emit warnings for every
> > demangler crash, not just the first.
>
> Umm, that's not what I said, to be precise, and it was more of a
> suggestion for discussion than a request.
Ah, I misunderstood.
>
> > I've not done this, my reason
> > being that subsequent failures could have been caused by the first,
> > by memory corruption or some leftover state: they could be bogus,
> > and could lead to us chasing bugs that don't exist. I prefer this
> > way, but I'm not hung up on it and if it's a blocker for Doug or
> > anyone else I will add the extra warnings.
>
> It's not a blocker to me.
Great :)
Thanks,
Gary
--
http://gbenson.net/