This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] PR mi/15806: Fix quoting of async events
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 5 Jun 2014 18:03:10 -0400
- Subject: Re: [PATCH v2] PR mi/15806: Fix quoting of async events
- Authentication-results: sourceware.org; auth=none
- References: <1401743738-29051-1-git-send-email-simon dot marchi at ericsson dot com> <87wqcv5dag dot fsf at fleche dot redhat dot com>
On 14-06-05 04:09 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> 2014-06-02 Simon Marchi <simon.marchi@ericsson.com>
>
> Simon> PR mi/15806
> Simon> * utils.c (printchar): Don't escape at all if quoter is NUL.
> Simon> Update function documentation to clarify effect of parameter
> Simon> QUOTER.
> Simon> * remote.c (escape_buffer): Pass '\\' as the quoter to
> Simon> fputstrn_unfiltered.
> Simon> * mi/mi-interp.c (mi_solib_loaded): Use ui_out_field_* functions to
> Simon> generate the output.
> Simon> (mi_solib_unloaded): Same.
>
> Simon> gdb/testsuite/ChangeLog:
>
> Simon> 2014-06-02 Simon Marchi <simon.marchi@ericsson.com>
>
> Simon> * gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify): Fix
> Simon> erroneous dprintf expected input.
>
> Thanks for the updates.
> This is ok with one nit fixed:
>
> Simon> -
> Simon> +
Ack.
> This seems to remove the form feed.
>
> Tom
Pushed, thanks.