This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 02/12] Generalize varobj iterator
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 05 Jun 2014 12:21:03 -0600
- Subject: Re: [PATCH 02/12] Generalize varobj iterator
- Authentication-results: sourceware.org; auth=none
- References: <1392367471-13527-1-git-send-email-yao at codesourcery dot com> <1392367471-13527-3-git-send-email-yao at codesourcery dot com> <874n0jkokw dot fsf at fleche dot redhat dot com> <537EA293 dot 2050000 at codesourcery dot com> <87k38wa0k6 dot fsf at fleche dot redhat dot com> <53900166 dot 7080900 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> Ah, you are right. Call varobj_ensure_python_env in
Yao> py_varobj_iter_dtor then.
Thanks.
Yao> 2014-06-05 Pedro Alves <pedro@codesourcery.com>
Yao> Yao Qi <yao@codesourcery.com>
Yao> * Makefile.in (SUBDIR_PYTHON_OBS): Add "py-varobj.o".
Yao> (SUBDIR_PYTHON_SRCS): Add "python/py-varobj.c".
Yao> (HFILES_NO_SRCDIR): Add "varobj-iter.h".
Yao> (py-varobj.o): New rule.
Yao> * python/py-varobj.c: New file.
Yao> * python/python-internal.h (py_varobj_get_iterator): Declare.
Yao> * varobj-iter.h: New file.
Yao> * varobj.c: Include "varobj-iter.h"
Yao> (struct varobj) <child_iter>: Change its type from "PyObject *"
Yao> to "struct varobj_iter *".
Yao> <saved_item>: Likewise.
Yao> [HAVE_PYTHON] (varobj_ensure_python_env): Make it extern.
Yao> [HAVE_PYTHON] (varobj_get_iterator): New function.
Yao> (update_dynamic_varobj_children) [HAVE_PYTHON]: Move
Yao> python-specific code to python/py-varobj.c.
Yao> (install_visualizer): Call varobj_iter_delete instead of
Yao> Py_XDECREF.
Yao> * varobj.h (varobj_ensure_python_env): Declare.
This is ok.
Tom